Hide empty outings in feed

[cbeauchesne]

This small modification will hide empty outings in home page.

It handle the case where cards are on user page, and in this case, it won't hide anything.

[brunobesson]

This should work. The problem is IMHO that this should be handled from the API side instead.
Anyway, to go forward, we could merge this in a first step. @asaunier what do you think?

[cbeauchesne]

Actually, I thought about this way to do thing. Regardless the fact that modify API is far from possible, it will be much more complicated : service should not be variable dependant, eg it should not filter results by default. So we must add a argument to this service, in order to allow &quality=empty,empty in url.

In my opinion, I think it's damn complicated, for such a specific usage.

[cbeauchesne]

arf je suis allé trop vite... dsl

Si faut rollbacker, dites moi.

[asaunier]

@asaunier what do you think?

Well, I guess it does the job (hide the empty outings from the feed except in the user profile one) and it is a quite simple change.
But isn't it a bit a hack? it's a bit a pity to load data that won't be loaded. As you said, it would make more sense to filter on the API side.

A problem we could have on the API side (which made me say it's not that simple to make that kind of filtering): I am not sure the quality attribute is available in the feed_document_changes table, making it easy to filter on that attribute. (edit: it's not) If we add the attribute to the table, we have to make sure it is updated when the actual quality of the document changes. Remember that feed cards are updated when creating the document, associating participants to an outing, uploading images => not when updating the document itself.

But perhaps it is easier than I think. For instance I have just tested on the demo and when I change the activity of an outing, the activity of the card is updated and the card is strip out from the feed if the new activity does not match the user's activities filter. Then perhaps we could use the same system for quality?

I have just created an API issue for this c2corg/v6_api#727 and assigned it to me in case I find time and motivation :P (I have the same difficulties to install the API and data on my laptop than you). Feel free to assign yourself too if you are interested.

[asaunier]

Say a user has created a bunch of empty outings recently. With this approach the home feed will load but all empty docs will be removed, leaving only a few items visible (or maybe none if all are empty) until the user scrolls the feed (if he figures out to do it...).
This doesn't look like a very robust solution 😉

I am working on a change on the API side c2corg/v6_api#728
Unfortunately I have no dev environment to work and test :/