Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: whohensee <[email protected]>
  • Loading branch information
rknop and whohensee authored Jul 17, 2024
1 parent 4056835 commit 7f8f06a
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion conductor/updater.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import json
import multiprocessing

# Have to manaully import any instrument modules
# Have to manually import any instrument modules
# we want to be able to find. (Otherwise, they
# won't be found when models.instrument is
# initialized.)
Expand Down
2 changes: 1 addition & 1 deletion hacks/rknop/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ db:
* Get a SSL cert for `ls4-conductor-rknop-dev.lbl.gov`
* Put the b64 encoded stuff in `conductor-cert.yaml` and apply it
* Uncomment the stuff in `conductor.yaml` and apply it
* Create user rknop manually in the conductor database (until such a time as the conductor has an actual interfrace for this).
* Create user rknop manually in the conductor database (until such a time as the conductor has an actual interface for this).
* (Once the ls4-conductor-rknop-dev.lbl.gov address is available.) Use the web interface to ls4-conductor-rknop-dev.lbl.gov to set rknop's password on the conductor. (Consider saving the database barf for the public and private keys to avoid having to do this upon database recreation.)

### Set up the archive
Expand Down
2 changes: 1 addition & 1 deletion models/knownexposure.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class KnownExposure(Base, AutoIDMixin):
Most fields are nullable because we can't be sure a priori how much
information we'll be able to get about known exposures before we
download them and start processing them -- they may only be a list
of filenames, for instance. exposuresurce must be known (because
of filenames, for instance. exposuresource must be known (because
that's where they come from), and we're assuming that the instrument
will be known. identifier required, and is some sort of unique
identifier that specifies this exposure; it's interpretation is
Expand Down
1 change: 0 additions & 1 deletion tests/fixtures/decam.py
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,6 @@ def decam_filename(download_url, data_dir, decam_exposure_name, decam_cache_dir)
cache.
"""
# base_name = 'c4d_221104_074232_ori.fits.fz'
base_name = decam_exposure_name
filename = os.path.join(data_dir, base_name)
os.makedirs(os.path.dirname(filename), exist_ok=True)
Expand Down

0 comments on commit 7f8f06a

Please sign in to comment.