-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CutoutsFile and Measurements #302
Conversation
I made a slight change from what Guy and I discussed about the If I forgot a useful case, feel free to let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very good work. It indeed ended up touching a lot of code but it looks in very good shape.
I have a bunch of small comments and corrections, but nothing major.
Make sure your migration hash matches the latest main, and once you fix all the comments you can squash and merge.
Please also try to run the |
Change the structure of the cutouts and measurements such that we have a CutoutsFile that saves all the cutouts and takes up a single row in DB as FileOnDiskMixin, and Measurements which point to the CutoutsFile for relevant information.
See #217 and #272