Provenance Tagging #338
Provenance Tagging #338
Conversation
…top_level.py::Pipeline.make_provenance_tree
…ting (documented in Issue c3-time-domain#339)
…tags. WEbap tests.
…end of every test, to try to track down some leftovers
…of return, so have to add next() in places where its used
| objects = get_all_database_objects( session=dbsession ) | ||
| any_objects = False | ||
| for Class, ids in objects.items(): | ||
| # TODO: check that surviving provenances have test_parameter |
There was a problem hiding this comment.
do you want to do this in this PR or leave it as a todo?
There was a problem hiding this comment.
Ah, I see that this is a remnant TODO from a prior PR
| # (This is probably not practical, becasuse there is *so much* module | ||
| # and session scope stuff that lots of things are left behind by tests. | ||
| # You will have to sift through a lot of output to find what you're | ||
| # looking for. We need a better way.) |
There was a problem hiding this comment.
Useful comment block, and I agree that we could use a better way down the line.
| assert len(rows) == 7 | ||
| # check stuff about the rows? | ||
|
|
||
| # There is probably more we should be testing here. Definitely. |
There was a problem hiding this comment.
We can robustify these tests down the line I think, but these look like a good starting point.
There was a problem hiding this comment.
Lots of stuff is going to be added to the webap, so tests will be added then.
| ) | ||
| subdict['provtag'] = data['provenancetag'] | ||
| # I wonder if making a primary key on the temp table would be more efficient than | ||
| # all these columns in GROUP BY? Investigate this. |
There was a problem hiding this comment.
I feel like I could take an entire day just studying this monstrous 3-part query! sqlalchemy has shielded me from pure SQL, mostly...
There was a problem hiding this comment.
Yeah, these things get kind of nasty.
Adding the provenance tags made these queries much more complicated.
webap/static/seechange.js
Outdated
| { "text": '"Detections" are everything found on subtratcions; ' + | ||
| '"Sources" are things that passed prelminary cuts.' } ) |
There was a problem hiding this comment.
| { "text": '"Detections" are everything found on subtratcions; ' + | |
| '"Sources" are things that passed prelminary cuts.' } ) | |
| { "text": '"Detections" are everything found on subtractions; ' + | |
| '"Sources" are things that passed preliminary cuts.' } ) |
There was a problem hiding this comment.
it wouldn't be a PR without a typo!
Human-readable tags associated with provenances. (Issue #337 )