Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the correct routes of the form management buttons #100

Merged
merged 16 commits into from
Feb 14, 2024
Merged

Add tests for the correct routes of the form management buttons #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4e833be
test: test that buttons are not visible in form states when they are …
PascalinDe Feb 7, 2024
adb9a7b
test: clean up test messages
PascalinDe Feb 7, 2024
1bac17b
test: add missing 'Canceled' state
PascalinDe Feb 7, 2024
525aaa8
test: add 'Vote' button test cases
PascalinDe Feb 7, 2024
18e6069
test: add initialization tests
PascalinDe Feb 7, 2024
312a3f9
test: add 'Setup' route calling test
PascalinDe Feb 8, 2024
7a80f95
test: add 'Open' route calling test
PascalinDe Feb 8, 2024
857c1f7
test: add 'Cancel' route calling test
PascalinDe Feb 8, 2024
f1784a1
test: refactor button tests and add tests for remaining buttons
PascalinDe Feb 9, 2024
65ed665
test: test adding voters
PascalinDe Feb 9, 2024
9180c8c
test: fix voting test
PascalinDe Feb 9, 2024
184bffa
fix: add missing route mocks
PascalinDe Feb 12, 2024
8a98808
style: fix linting warnings
PascalinDe Feb 12, 2024
e3364c7
fix: add missing file
PascalinDe Feb 13, 2024
36b99cf
refactor: apply review suggestions
PascalinDe Feb 13, 2024
36b9486
style: fix linter
PascalinDe Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web/frontend/src/pages/form/components/AddVotersModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ export const AddVotersModal: FC<AddVotersModalProps> = ({
</div>
<div className="bg-gray-50 px-4 py-3 sm:px-6 sm:flex sm:flex-row-reverse">
<button
data-testid="addVotersConfirm"
type="button"
className="w-full inline-flex justify-center rounded-md border border-transparent shadow-sm px-4 py-2 bg-indigo-600 text-base font-medium text-white hover:bg-indigo-700 focus:outline-none focus:ring-2 focus:ring-offset-2 focus:ring-indigo-500 sm:ml-3 sm:w-auto sm:text-sm"
onClick={confirmChoice}>
Expand Down
4 changes: 3 additions & 1 deletion web/frontend/src/pages/form/components/ChooseProxyModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,9 @@ const ChooseProxyModal: FC<ChooseProxyModalProps> = ({
<div className="mx-auto flex-shrink-0 flex items-center justify-center h-12 w-12 rounded-full bg-indigo-100 sm:mx-0 sm:h-10 sm:w-10">
<CogIcon className="h-6 w-6 text-indigo-600" aria-hidden="true" />
</div>
<div className="mt-3 text-center sm:mt-0 sm:ml-4 sm:text-left">
<div
data-testid="nodeSetup"
className="mt-3 text-center sm:mt-0 sm:ml-4 sm:text-left">
<Dialog.Title as="h3" className="text-lg leading-6 font-medium text-gray-900">
{t('nodeSetup')}
</Dialog.Title>
Expand Down
Loading
Loading