Add remaining ballots tests #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalinDe
force-pushed
the
playwright
branch
from
e26dd9f
to
a0abffd
Compare
ineiti
approved these changes
Feb 16, 2024
|
|
||
| test('Assert ballot is displayed properly', async ({ page }) => { | ||
| const content = await page.getByTestId('content'); | ||
| // TODO integrate localisation |
There was a problem hiding this comment.
Is this on the agenda? Or a "Far in the future" TODO?
There was a problem hiding this comment.
this is a reminder that this test is not taking into account localisation (there is a ticket for testing the localisation in general)
so it is a "if/when you implement the tests for the localisation, do not forget to adapt this one" as I took care to make all the other tests are localisation-independent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the remaining voting tests and closes #99 .