Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding versions #148

Merged
merged 1 commit into from
Mar 8, 2024
Merged

adding versions #148

merged 1 commit into from
Mar 8, 2024

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Mar 8, 2024

This shows the current version of the build

Closes #145

Thank you for opening a pull request with this project, please also:

  • add a brief description of your changes here
  • assign the PR to yourself, or to the person(s) working on it
  • start in draft mode and in progress pipeline in the project (if applicable)
  • if applicable, add this PR to its related issue by one of the special keywords Closing keywords
  • once it's ready
    • put it in the Review or Ready4Merge pipeline in the project (if applicable)
    • remove draft
    • assign a reviewer

@ineiti ineiti self-assigned this Mar 8, 2024
@ineiti ineiti force-pushed the version_display branch 4 times, most recently from 9fd1e33 to 53fcdca Compare March 8, 2024 13:00
Copy link
Member

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, can you add the variables to the .example.env file as well?

@ineiti
Copy link
Member Author

ineiti commented Mar 8, 2024

cool, can you add the variables to the .example.env file as well?

No - my goal is to have the ENV variables directly in the docker image. Why should you want to change the version numbers in the .env file? Then you would have to update the version numbers if you get a new docker image.

But now I see why it doesn't work, because I forgot to change the Dockerfile.frontend

This shows the current version of the build
@PascalinDe
Copy link
Member

cool, can you add the variables to the .example.env file as well?

No - my goal is to have the ENV variables directly in the docker image. Why should you want to change the version numbers in the .env file? Then you would have to update the version numbers if you get a new docker image.

But now I see why it doesn't work, because I forgot to change the Dockerfile.frontend

ah, yes, that makes sense, approved now

@ineiti ineiti merged commit f8d78b8 into main Mar 8, 2024
12 checks passed
@ineiti ineiti deleted the version_display branch March 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Increase version number
2 participants