Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only pushing if merge on main #171

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Only pushing if merge on main #171

merged 1 commit into from
Jul 3, 2024

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Jul 3, 2024

With this PR, the docker images are built, but only pushed when the action is run on the 'main' branch.

Thank you for opening a pull request with this project, please also:

  • add a brief description of your changes here
  • assign the PR to yourself, or to the person(s) working on it
  • start in draft mode and in progress pipeline in the project (if applicable)
  • if applicable, add this PR to its related issue by one of the special keywords Closing keywords
  • once it's ready
    • put it in the Review or Ready4Merge pipeline in the project (if applicable)
    • remove draft
    • assign a reviewer

@ineiti ineiti force-pushed the test_docker_build branch 3 times, most recently from abe8014 to b7eddae Compare July 3, 2024 12:36
With this PR, the docker images are built, but only pushed when the
action is run on the 'main' branch.
@ineiti ineiti self-assigned this Jul 3, 2024
@ineiti ineiti requested a review from PascalinDe July 3, 2024 12:41
Copy link
Member

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ineiti ineiti merged commit 572e945 into main Jul 3, 2024
11 checks passed
@ineiti ineiti deleted the test_docker_build branch July 3, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants