Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly create new keys #64

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Correctly create new keys #64

merged 1 commit into from
Nov 24, 2023

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Nov 24, 2023

The new keys couldn't be created when the backend was not running. Fixed it by calling the backend only when necessary.

Thank you for opening a pull request with this project, please also:

  • add a brief description of your changes here
  • assign the PR to yourself, or to the person(s) working on it
  • start in draft mode and in progress pipeline in the project (if applicable)
  • if applicable, add this PR to its related issue by one of the special keywords Closing keywords
  • once it's ready
    • put it in the Review or Ready4Merge pipeline in the project (if applicable)
    • remove draft
    • assign a reviewer

The new keys couldn't be created when the backend was not running.
Fixed it by calling the backend only when necessary.
@ineiti ineiti self-assigned this Nov 24, 2023
Copy link
Member

@PascalinDe PascalinDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ineiti ineiti merged commit e702098 into main Nov 24, 2023
11 checks passed
@ineiti ineiti deleted the fix_scripts branch November 24, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants