Action Buttons that manipulate a form are only visible to the owner #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
approved these changes
Feb 7, 2024
| @@ -74,3 +81,77 @@ async function assertIsOnlyVisibleToOwnerStates(page: page, locator: locator, st | |||
| test('Assert "Add voters" button is only visible to owner', async ({ page }) => { | |||
| await assertIsOnlyVisibleToOwnerStates(page, page.getByTestId('addVotersButton'), [0, 1]); | |||
| }); | |||
|
|
|||
| test('Assert "Initialize" button is only visible to owner', async ({ page }) => { | |||
There was a problem hiding this comment.
Lazy review: are there positive tests on the buttons where it checks that the buttons are available?
There was a problem hiding this comment.
or at least not all of them - e.g. it checks that the buttons that are should only be visible to owner are:
- not visible to unauthenticated
- not visible to non-owner user
- not visible to non-owner admin
- visible to owner
but it does not e.g. check that the "Vote" button is visible for voters
There was a problem hiding this comment.
also it checks only in specific states, e.g. it does not verify that the buttons are not displayed in other states where they are not applicable at all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that action buttons to manipulate a form are only visible to the owner of the form.
closes #80