Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e fixes #19

Merged
merged 7 commits into from
Mar 1, 2024
Merged

E2e fixes #19

merged 7 commits into from
Mar 1, 2024

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Feb 28, 2024 •
edited
Loading

Various fixes found during end-to-end testing:

  • Remove existing socket file upon startup
  • Increase logging
  • Put fast block sync into a unique place
  • Fix comparisons and updates of block indexes and nonces
  • Doing some magic timeout adjustments

When merging this PR, don't forget to update c4dt/d-voting/go.mod

@ineiti ineiti self-assigned this Feb 28, 2024
@ineiti ineiti force-pushed the e2e_fixes branch 3 times, most recently from f368cf3 to 45456bc Compare February 29, 2024 16:01
@ineiti ineiti marked this pull request as ready for review March 1, 2024 07:10
@ineiti ineiti requested a review from PascalinDe March 1, 2024 07:11
@ineiti ineiti merged commit 73bff7b into main Mar 1, 2024
4 checks passed
@ineiti ineiti deleted the e2e_fixes branch March 1, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PascalinDe PascalinDe PascalinDe approved these changes

Assignees

@ineiti ineiti

Labels
None yet
Projects
D-Voting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ineiti @PascalinDe