Fixing race condition and adding fuzzy test #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
force-pushed
the
fix_failing_test
branch
5 times, most recently
from
d198f79 to
2906a6f
Compare
Closed
|
looks good to me - is the reason for some tests being flaky documented somewhere? |
|
No, I don't know the reason :( For most of the tests, I can't even reproduce the flakiness on my computer... |
ineiti
force-pushed
the
fix_failing_test
branch
from
69a7e41 to
369fb61
Compare
- There was a race-condition in the echoHandler which made it fail on fast machines. - Changed the tests to wait for the accurate number of messages, instead of waiting for 2 seconds. - Also fixed an incompatibility in the Makefile wrt the github runners. - Added a test to the fuzzy tests in the Makefile
ineiti
force-pushed
the
fix_failing_test
branch
from
369fb61 to
1097ad3
Compare
ineiti
changed the title
Added an issue: dedis#291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shinstead ofbash