Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API client update about Mutation Assessor v4 data and UI changes #5015

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

leexgh
Copy link
Member

@leexgh leexgh commented Oct 2, 2024

Part of: genome-nexus/genome-nexus#753
There are some API model changes about Mutation Assessor v4 in genome nexus. This pr changes data display and tooltip text to work with new data
Header tooltip:
image
Data and tooltip:
image

Test link (need to add Functional Impact in column dropdown): https://deploy-preview-5015.cancerrevue.org/results/mutations?cancer_study_list=msk_impact_2017&Z_SCORE_THRESHOLD=2.0&RPPA_SCORE_THRESHOLD=2.0&profileFilter=mutations%2Cstructural_variants%2Ccna&case_set_id=msk_impact_2017_cnaseq&gene_list=BRAF&geneset_list=%20&tab_index=tab_visualize&Action=Submit

Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit 6cdc6a3
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/66fefc7b15cbdb00087dc76d
😎 Deploy Preview https://deploy-preview-5015.cancerrevue.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@leexgh leexgh added the cl-package Improvements related to a package label Oct 2, 2024
@leexgh leexgh requested a review from onursumer October 3, 2024 14:27
@leexgh leexgh changed the title Changes to fit with new Mutation Assessor data model API client update about Mutation Assessor v4 data and UI changes Oct 3, 2024
Copy link
Member

@onursumer onursumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just added a few minor suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cl-package Improvements related to a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants