Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMI2-644 get failed grant export count #205

Conversation

rachelswart
Copy link
Contributor

@rachelswart rachelswart commented Feb 22, 2024

Description

Adds an endpoint to get the number of grant exports with a given status
This should also cover this ticket: https://technologyprogramme.atlassian.net/browse/TMI2-638

Ticket # and link
TMI2-644: https://technologyprogramme.atlassian.net/browse/TMI2-644

Summary of the changes and the related issue. List any dependencies that are required for this change:

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End-to-End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed dependencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have run cypress tests, and they all pass locally.

@rachelswart rachelswart merged commit c4869e9 into TMI2-600_new_submission_export Feb 22, 2024
3 checks passed
rachelswart added a commit that referenced this pull request Mar 4, 2024
* TMI2-644 get failed grant export count (#205)

* added getExportCountByStatus endpoint

* added type to ResponseEntity

* Tmi2 641 645/return list of exported submissions (#207)

* add endpoint to grab paginated list of exported submissions based on the status

* add fix, to retrieve results only for logged admin

* merge conflicts

* make the endpoint, the single source of data for the page, remove exportbatch controller and merge it in export controller

* update spring Security white list with updated endpoints

* fix test

* fix lambda interceptor list

* address comments

* TMI2-600 - Updating DTO mapping

* TMI2-669: download attachments error path (#214)

* added getSubmission endpoint

* cleanup

* added ResponseEntity<SubmissionDto> return type

* updated target name in grant export mapper

* added endpoint and DTO to get failed grant export

* updated grant export mapper for v2 grants

---------

Co-authored-by: a-lor-cab <[email protected]>
Co-authored-by: Jim Purvis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants