Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAP-2510: Fixing errors caused by setting last updated fields on grant adverts #254

Merged

Conversation

GavCookCO
Copy link
Contributor

@GavCookCO GavCookCO commented Mar 18, 2024

Description

Fixing errors caused by setting the last updated dates on grant adverts when authenticated as an anonymous user. This occurs when one of our lambdas performs updates on a grant advert.

Ticket # and link
GAP-2510

Summary of the changes and the related issue. List any dependencies that are required for this change:
Added a helper method to check whether an authenticated session is anonymous or not and then called this before saving a grant advert.

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End-to-End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed dependencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have run cypress tests, and they all pass locally.

@GavCookCO GavCookCO merged commit 7ceb01e into develop Mar 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants