Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAP-2523: Super admin only grant ownership #289

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

paul-lawlor-tco
Copy link
Contributor

Description

GAP-2523: https://technologyprogramme.atlassian.net/browse/GAP-2523

Clean up logic to make call to user service regardless of role to fix issue where user with only SUPER ADMIN role couldn't have a grant transferred to them.

Summary of the changes and the related issue. List any dependencies that are required for this change:

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End-to-End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed dependencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have run cypress tests, and they all pass locally.

Copy link

@tco-olivergodby tco-olivergodby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - Merge when ready...

@ConorFayleTCO ConorFayleTCO merged commit 0702972 into develop Apr 17, 2024
3 checks passed
@ConorFayleTCO ConorFayleTCO deleted the fix/GAP-2523-fix-uri-logic branch April 17, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants