fix client-side js crashing in webkit and firefox (#99)

* fix client-side js crashing in webkit and firefox * fix cookies error * rm * also fix in admin
cabinetoffice · Oct 12, 2023 · 5bce0e8 · 5bce0e8
1 parent e8342eb
commit 5bce0e8
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/packages/admin/src/pages/_app.page.js b/packages/admin/src/pages/_app.page.js
@@ -48,7 +48,8 @@ const MyApp = ({ Component, pageProps, cookies }) => {
 
 MyApp.getInitialProps = async (appContext) => {
   const appProps = await App.getInitialProps(appContext);
-  const cookies = appContext.ctx.req.cookies;
+  const cookies =
+    typeof window === 'undefined' ? {} : appContext.ctx.req.cookies;
   return { ...appProps, cookies };
 };
 

diff --git a/packages/applicant/src/pages/_app.page.js b/packages/applicant/src/pages/_app.page.js
@@ -48,7 +48,8 @@ const MyApp = ({ Component, pageProps, cookies }) => {
 
 MyApp.getInitialProps = async (appContext) => {
   const appProps = await App.getInitialProps(appContext);
-  const cookies = appContext.ctx.req.cookies;
+  const cookies =
+    typeof window === 'undefined' ? {} : appContext.ctx.req.cookies;
   return { ...appProps, cookies };
 };
 

diff --git a/packages/gap-web-ui/rollup.config.js b/packages/gap-web-ui/rollup.config.js
@@ -31,6 +31,7 @@ export default [
         extract: true,
       }),
     ],
+    external: ['depd'],
   },
   {
     input: 'dist/esm/types/index.d.ts',