Next 14 & app router #333
Closed
Next 14 & app router #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominicwest
commented
Feb 20, 2024
| @@ -47,7 +47,8 @@ | |||
| "semver": "^7.5.2", | |||
| "word-wrap": "^1.2.4", | |||
| "@babel/traverse": "7.23.2", | |||
| "parse-url": "8.1.0" | |||
| "parse-url": "8.1.0", | |||
| "domino": "Haringat/domino#2721294c75334ece635dfc72cad0a3dede7391fb" | |||
There was a problem hiding this comment.
Defo want a better way of fixing this but gap-web-ui's turndown dependency uses domino which uses some deprecated JS syntax that we dont allow due to using strict mode. This commit replaces the deprecated JS syntax
dominicwest
commented
Feb 20, 2024
dominicwest
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating dashboard pages to nexts app router.
Takes advantage of rendering components on the server (React Server Components: RSC) by default, which allows us to completely scrap getServerSideProps and make requests from the component itself.
Additionally can take advantage of "Server actions" which let you submit forms to a server action that executes server side.
This PR includes:
TODO: