Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX TMI2-733: Advert Preview #431

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

IlyasBaqqari-CabinetOffice
Copy link
Contributor

@IlyasBaqqari-CabinetOffice IlyasBaqqari-CabinetOffice commented Apr 11, 2024

Description

TMI2-733

Fixing an issue encountered with this feature where a 500 error is given on the search-result preview page.

This change adds the dependency moment-timezone to admin-backend in an attempt to fix the issue.

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End to End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed dependencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have ran cypress tests and they all pass locally.

@IlyasBaqqari-CabinetOffice IlyasBaqqari-CabinetOffice merged commit ffcdb10 into develop Apr 11, 2024
15 checks passed
@IlyasBaqqari-CabinetOffice IlyasBaqqari-CabinetOffice changed the title FIX TMI2-773: Advert Preview FIX TMI2-733: Advert Preview Apr 11, 2024
@IlyasBaqqari-CabinetOffice IlyasBaqqari-CabinetOffice deleted the TMI2-773-advert-preview-fix branch April 11, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants