-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAP-2521: bump out of date dependencies #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good - please merge when ready.
> | ||
{adjustedCloseDate} | ||
</Moment> | ||
<time data-testid="closeDate">{adjustedCloseDate}</time> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we preserving the formatting here? There were a couple tickets recently around this so just making sure we're not regressing that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be, there are tests for it that I ensured were passing
newDate.tz('GMT').format('D MMMM YYYY, h:mma');
is the same formatting and timezone as was originally present, and <Moment/>
is rendered as <time/>
so everything should be exactly the same
Description
GAP-2521
Bumping all minor and patch versions of packages in this repo. Major versions will be documented as we don't have time to fix the breaking changes.
Had to refactor some react-moment code as it was having an issue with moment-timezone props.
all
// eslint-disable-next-line @next/next/no-server-import-in-page
lines have also been removed due to the upgrade of eslintType of change
Please check the relevant options.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes:
Unit Test
Integration Test (if applicable)
End to End Test (if applicable)
Screenshots (if appropriate):
Please attach screenshots of the change if it is a UI change:
Checklist: