Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAP-2521: bump out of date dependencies #447

Merged
merged 8 commits into from
Apr 25, 2024

Conversation

ConorFayleTCO
Copy link
Contributor

@ConorFayleTCO ConorFayleTCO commented Apr 18, 2024

Description

GAP-2521

Bumping all minor and patch versions of packages in this repo. Major versions will be documented as we don't have time to fix the breaking changes.

Had to refactor some react-moment code as it was having an issue with moment-timezone props.

all // eslint-disable-next-line @next/next/no-server-import-in-page lines have also been removed due to the upgrade of eslint

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End to End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed dependencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have ran cypress tests and they all pass locally.

@ConorFayleTCO ConorFayleTCO marked this pull request as ready for review April 22, 2024 09:43
@ConorFayleTCO ConorFayleTCO changed the title Feature/gap 2521 out of date deps GAP-2521: bump out of date dependencies Apr 22, 2024
Copy link
Contributor

@tco-olivergodby tco-olivergodby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - please merge when ready.

>
{adjustedCloseDate}
</Moment>
<time data-testid="closeDate">{adjustedCloseDate}</time>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we preserving the formatting here? There were a couple tickets recently around this so just making sure we're not regressing that

Copy link
Contributor Author

@ConorFayleTCO ConorFayleTCO Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be, there are tests for it that I ensured were passing
newDate.tz('GMT').format('D MMMM YYYY, h:mma'); is the same formatting and timezone as was originally present, and <Moment/> is rendered as <time/> so everything should be exactly the same

@ConorFayleTCO ConorFayleTCO merged commit 63a155c into develop Apr 25, 2024
15 checks passed
@ConorFayleTCO ConorFayleTCO deleted the feature/GAP-2521-out-of-date-deps branch April 25, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants