2117 Notice Page Feature Flag #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has this been tested locally? Can you do a short screen recording with One Login enabled/disabled please? |
The two screenshots are locally taken. Is there anything in particular you'd like a video to confirm? |
Screen.Recording.2023-08-25.at.10.39.42.movScreen.Recording.2023-08-25.at.10.37.05.mov@dylanwrightCO Believe the login on Cola is pointing the right location, I've just not local setup for cola logins |
dylanwrightCO
approved these changes
Aug 25, 2023
dylanwrightCO
added a commit
that referenced
this pull request
Aug 28, 2023
* Added conditional logic to page displayed based on feature flag value (#57) * fix(manage-departments): fixes how headings are added to department rows (#58) Co-authored-by: Dylan Wright <[email protected]> * fix redirect to application * GAP-2127 custom error page for deleting a department with users assigned (#59) * GAP-2126 - Adds back link to dashboard on 'Your sign in details' page --------- Co-authored-by: ryan-tco <[email protected]> Co-authored-by: Dylan Wright <[email protected]> Co-authored-by: JamieGunnCO <[email protected]> Co-authored-by: dominicwest <[email protected]> Co-authored-by: jgunnCO <[email protected]> Co-authored-by: kiramarstonTCO <[email protected]> Co-authored-by: kiramarstonTCO <[email protected]>
ryan-tco
added a commit
that referenced
this pull request
Sep 6, 2023
* Added conditional logic to page displayed based on feature flag value (#57) * fix(manage-departments): fixes how headings are added to department rows (#58) Co-authored-by: Dylan Wright <[email protected]> * fix redirect to application * GAP-2127 custom error page for deleting a department with users assigned (#59) * GAP-2126 - Adds back link to dashboard on 'Your sign in details' page --------- Co-authored-by: ryan-tco <[email protected]> Co-authored-by: Dylan Wright <[email protected]> Co-authored-by: JamieGunnCO <[email protected]> Co-authored-by: dominicwest <[email protected]> Co-authored-by: jgunnCO <[email protected]> Co-authored-by: kiramarstonTCO <[email protected]> Co-authored-by: kiramarstonTCO <[email protected]>
ryan-tco
added a commit
that referenced
this pull request
Sep 6, 2023
* Added conditional logic to page displayed based on feature flag value (#57) * fix(manage-departments): fixes how headings are added to department rows (#58) Co-authored-by: Dylan Wright <[email protected]> * fix redirect to application * GAP-2127 custom error page for deleting a department with users assigned (#59) * GAP-2126 - Adds back link to dashboard on 'Your sign in details' page --------- Co-authored-by: ryan-tco <[email protected]> Co-authored-by: Dylan Wright <[email protected]> Co-authored-by: JamieGunnCO <[email protected]> Co-authored-by: dominicwest <[email protected]> Co-authored-by: jgunnCO <[email protected]> Co-authored-by: kiramarstonTCO <[email protected]> Co-authored-by: kiramarstonTCO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature flag off/on