Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GAP-2230: frontend times out when requesting many submissions #90

Merged
merged 13 commits into from
Oct 11, 2023
Merged

GAP-2230: frontend times out when requesting many submissions #90

merged 13 commits into from
Oct 11, 2023

Conversation

dominicwest
Copy link
Contributor

@dominicwest dominicwest commented Oct 10, 2023 •
edited
Loading

Description

Ticket 2230

Summary of the changes and the related issue. List any dependencies that are required for this change:

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End to End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed depedenencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have ran cypress tests and they all pass locally.

@dominicwest dominicwest merged commit f7fcbb6 into develop Oct 11, 2023
1 check passed
dylanwrightCO pushed a commit that referenced this pull request Oct 17, 2023
@dominicwest @iaincooper-tco
@ryan-tco @ConorFayleTCO @ConorFayleAND @john-tco @jgunnCO @paul-lawlor-tco @a-lor-cab
Release/3.6 (#91)
217bdf8 
* TMI2-253: Add pre-commit check and update .gitignore to include application-local.properties and .env.local

* Added conditional logic to display department on user page (#72)

* GAP-2129 remove call to email findagrant for posting application form to grant advert (#66)

* GAP-2129 | remove instruction to email findagrant for adding application form to grant advert

* GAP-2129|make changes to copy as per GDS styling

* Changed copy to be consistent with the description shown to applicants for file upload.

* GAP-2230: frontend times out when requesting many submissions (#90)

* GAP-2230: Removing await so it calls the backend to start sending messages to SQS and doesnt wait for its response

* Cache dependencies on failure

* Separating out pipelines to admin/applicant/gap-web-ui (#100)

### Continuous Integration

- Separating out feature workflow into each package
- Triggering on paths related to the specific package plus some others, e.g. for the admin app:
 ```      
      - "packages/admin/**"
      - ".github/workflows/admin-feature.yml"
      - "package.json"
      - "yarn.lock"
```
- This results in if you only ever change the admin app during a PR, then only this pipeline runs.
- If you also e.g. change the applicant app mid way through, both workflows must pass
- Caching dependencies using node-setup@v3
- Separating out Snyk as a new workflow

### Continuous Deployment

- Separated into multiple workflows and triggering with the same path changes as before, but with the addition of any changes to gap-web-ui i.e:
```
      - "packages/admin/**"
      - "packages/gap-web-ui/**"
      - ".github/workflows/admin-pushImage.yml"
      - "package.json"
      - "yarn.lock"

---------

Co-authored-by: Iain Cooper <[email protected]>
Co-authored-by: iaincooper-tco <[email protected]>
Co-authored-by: ryan-tco <[email protected]>
Co-authored-by: ConorFayleTCO <[email protected]>
Co-authored-by: conor <[email protected]>
Co-authored-by: john-tco <[email protected]>
Co-authored-by: jgunnCO <[email protected]>
Co-authored-by: paul-lawlor-tco <[email protected]>
Co-authored-by: JamieGunnCO <[email protected]>
Co-authored-by: a-lor-cab <[email protected]>
ConorFayleTCO added a commit that referenced this pull request Jan 26, 2024
@ConorFayleTCO @dependabot
@dylanwrightCO @jgunnCO @paul-lawlor-tco @a-lor-cab @dominicwest @iaincooper-tco @ryan-tco @ConorFayleAND @john-tco @rachelswart @jimpurvisTCO @jpurvis-and @GavCookCO
merge release/8.0 into develop (#274)
e96ef3b 
* Bump word-wrap from 1.2.3 to 1.2.4

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Release/3.0 (#56)

Release/3.0

* Release/3.3 (#82)

Release 3.3

* Release/3.4 (#84)

* The correct copy for Document Upload now appears for admins on the service.
* fixes issue with users using safari


---------

Co-authored-by: paul-lawlor-tco <[email protected]>
Co-authored-by: JamieGunnCO <[email protected]>

* Revert "Bump word-wrap from 1.2.3 to 1.2.4"

* Release/3.6 (#91)

* TMI2-253: Add pre-commit check and update .gitignore to include application-local.properties and .env.local

* Added conditional logic to display department on user page (#72)

* GAP-2129 remove call to email findagrant for posting application form to grant advert (#66)

* GAP-2129 | remove instruction to email findagrant for adding application form to grant advert

* GAP-2129|make changes to copy as per GDS styling

* Changed copy to be consistent with the description shown to applicants for file upload.

* GAP-2230: frontend times out when requesting many submissions (#90)

* GAP-2230: Removing await so it calls the backend to start sending messages to SQS and doesnt wait for its response

* Cache dependencies on failure

* Separating out pipelines to admin/applicant/gap-web-ui (#100)

### Continuous Integration

- Separating out feature workflow into each package
- Triggering on paths related to the specific package plus some others, e.g. for the admin app:
 ```      
      - "packages/admin/**"
      - ".github/workflows/admin-feature.yml"
      - "package.json"
      - "yarn.lock"
```
- This results in if you only ever change the admin app during a PR, then only this pipeline runs.
- If you also e.g. change the applicant app mid way through, both workflows must pass
- Caching dependencies using node-setup@v3
- Separating out Snyk as a new workflow

### Continuous Deployment

- Separated into multiple workflows and triggering with the same path changes as before, but with the addition of any changes to gap-web-ui i.e:
```
      - "packages/admin/**"
      - "packages/gap-web-ui/**"
      - ".github/workflows/admin-pushImage.yml"
      - "package.json"
      - "yarn.lock"

---------

Co-authored-by: Iain Cooper <[email protected]>
Co-authored-by: iaincooper-tco <[email protected]>
Co-authored-by: ryan-tco <[email protected]>
Co-authored-by: ConorFayleTCO <[email protected]>
Co-authored-by: conor <[email protected]>
Co-authored-by: john-tco <[email protected]>
Co-authored-by: jgunnCO <[email protected]>
Co-authored-by: paul-lawlor-tco <[email protected]>
Co-authored-by: JamieGunnCO <[email protected]>
Co-authored-by: a-lor-cab <[email protected]>

* Create DUMMY

* DUMMY file to force image push

* only display due diligence btn for V2 (#157) (#159)

Co-authored-by: rachelswart <[email protected]>

* Fixing linting error

* TMI2-499: Fixing layout of unpublish application page (#203) (#204)

* remove unused files

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dylanwrightCO <[email protected]>
Co-authored-by: JamieGunnCO <[email protected]>
Co-authored-by: jgunnCO <[email protected]>
Co-authored-by: paul-lawlor-tco <[email protected]>
Co-authored-by: a-lor-cab <[email protected]>
Co-authored-by: dominicwest <[email protected]>
Co-authored-by: Iain Cooper <[email protected]>
Co-authored-by: iaincooper-tco <[email protected]>
Co-authored-by: ryan-tco <[email protected]>
Co-authored-by: conor <[email protected]>
Co-authored-by: john-tco <[email protected]>
Co-authored-by: dominicwest <[email protected]>
Co-authored-by: rachelswart <[email protected]>
Co-authored-by: jimpurvisTCO <[email protected]>
Co-authored-by: Jim Purvis <[email protected]>
Co-authored-by: a-lor-cab <[email protected]>
Co-authored-by: Gavin Cook <[email protected]>
Co-authored-by: GavCookCO <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylanwrightCO dylanwrightCO dylanwrightCO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominicwest @dylanwrightCO