Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAP-2230: Fixing download submissions page #92

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

dominicwest
Copy link
Contributor

@dominicwest dominicwest commented Oct 11, 2023

Description

GAP-2230

Summary of the changes and the related issue. List any dependencies that are required for this change:
Refactoring so that the page only makes one request max, and conditionalises sending the batch request on if they've hit the button

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End to End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Screen.Recording.2023-10-11.at.14.16.20.mov

Checklist:

  • If I have listed depedenencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have ran cypress tests and they all pass locally.

@dominicwest dominicwest marked this pull request as ready for review October 11, 2023 13:28
@dominicwest dominicwest merged commit 1a2ba95 into develop Oct 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants