Updates notification unsubscribe logic (Gets data from Notification table instead of JWT)

[john-tco]

Description

GAP-2152

Reads unsubscribe reference data from the unsubscribe table rather than decoding the JWT.

related prs: cabinetoffice/gap-find-backend#59, cabinetoffice/gap-user-service#135

Type of change

Please check the relevant options.

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).
• This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

• Unit Test

• Integration Test (if applicable)

• End to End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

• If I have listed dependencies above, I have ensured that they are present in the target branch.
• I have performed a self-review of my code.
• I have commented my code in hard-to-understand areas.
• I have made corresponding changes to the documentation where applicable.
• I have ran cypress tests and they all pass locally.

[dominicwest]

What's the difference between these calls? Is there a reason they're separate? From their names sounds like handleUnsubscribe does not actually unsubscribe you and we need this additional separate step. If that's the case, would suggest merging the endpoints it calls into one potentially

[john-tco]

handleUnsubscribe calls existing endpoints to remove notifications rows, these endpoints are accessed elsewhere in the app and they will in fact unsubscribe you. RemoveUnsubscribeReference is a new endpoint just to cleanup the unsubscribe reference table. We probably could combine these if we think it's significantly better / want to make the existing endpoints more generic

[john-tco]

have combined these calls with the lastest commits