Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAP-2523 #201

Merged
merged 4 commits into from
Apr 16, 2024
Merged

GAP-2523 #201

merged 4 commits into from
Apr 16, 2024

Conversation

paul-lawlor-tco
Copy link
Contributor

@paul-lawlor-tco paul-lawlor-tco commented Apr 15, 2024

Description

GAP-2523: https://technologyprogramme.atlassian.net/browse/GAP-2523

Ensures that a Super Admin can change the ownership of a grant without having the admin role
This does not explicitly address the ticket, although is a necessary requirement for Super Admins which have already been promoted (and therefore do not have the Admin role).

Summary of the changes and the related issue. List any dependencies that are required for this change:
ADMIN BE PR: cabinetoffice/gap-find-admin-backend#286
APPLY FE PR: cabinetoffice/gap-find-apply-web#439

Type of change

Please check the relevant options.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes:

  • Unit Test

  • Integration Test (if applicable)

  • End to End Test (if applicable)

Screenshots (if appropriate):

Please attach screenshots of the change if it is a UI change:

Checklist:

  • If I have listed dependencies above, I have ensured that they are present in the target branch.
  • I have performed a self-review of my code.
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the documentation where applicable.
  • I have ran cypress tests and they all pass locally.

Copy link

@tco-olivergodby tco-olivergodby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go - merge when ready

@paul-lawlor-tco paul-lawlor-tco merged commit a3e4cc3 into develop Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants