Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTRNL-450 - Add auth middleware #21

Closed
wants to merge 11 commits into from
Closed

NTRNL-450 - Add auth middleware #21

wants to merge 11 commits into from

Conversation

mel-am
Copy link
Contributor

@mel-am mel-am commented Jun 19, 2024 •
edited
Loading

JIRA link

Resolves NTRNL-450

Description

Add Authentication MW and feature flag to node-web-template

Work checklist

  • Tests added where applicable
  • No vulnerability added

@mel-am mel-am self-assigned this Jun 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 100% 187/187
🟢 Branches
94.44% (+0.33% 🔼)
 17/18
🟢 Functions 100% 19/19
🟢 Lines 100% 168/168
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / authentication.middleware.ts
 100% 100% 100% 100%
🟢
... / isFeatureEnabled.ts
 100% 100% 100% 100%

Test suite run success

36 tests passing in 20 suites.

Report generated by 🧪jest coverage report action from fbd5264

@harley-harris
Copy link
Contributor

harley-harris commented Jun 24, 2024 •
edited
Loading

The FEATURE_FLAG_ENABLE_AUTH environment variable is missing from env.example and docker-compose.yml, could you add it please?

You could change env.example to match the github-requests format too, alphabetically arranged variable names and no double quotes for single word values.

@mel-am mel-am requested a review from harley-harris June 24, 2024 15:24
@mel-am mel-am closed this Jun 25, 2024
@mel-am mel-am deleted the 450-add-auth-mw branch June 25, 2024 10:47
@mel-am mel-am restored the 450-add-auth-mw branch June 25, 2024 10:49
@mel-am mel-am reopened this Jun 25, 2024
@mel-am mel-am requested a review from harley-harris June 28, 2024 10:45
@mel-am mel-am force-pushed the 450-add-auth-mw branch from 03af941 to fcebeab Compare July 4, 2024 11:56
@mel-am mel-am requested a review from Mouhajer-CO July 4, 2024 15:31
@mel-am mel-am requested a review from a team July 4, 2024 15:32
@mel-am
Copy link
Contributor Author

mel-am commented Jul 4, 2024

Thanks @DanielMurray97 for your support on this ticket.

Mouhajer-CO
Mouhajer-CO reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@Mouhajer-CO Mouhajer-CO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mel-am could you please check your linting configuration on your local machine, a few files and lines of code seems off, thanks 🙏

src/middleware/authentication.middleware.ts Outdated Show resolved Hide resolved
@mel-am mel-am requested a review from Mouhajer-CO July 5, 2024 16:39
@harley-harris
Copy link
Contributor

PR has been closed as Melissa has left the team and implementation was left unfinished. It has been superceded by #29.

@harley-harris harley-harris mentioned this pull request Jul 10, 2024
Merged
2 tasks
@harley-harris harley-harris deleted the 450-add-auth-mw branch July 11, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielMurray97 DanielMurray97 Awaiting requested review from DanielMurray97

@harley-harris harley-harris Awaiting requested review from harley-harris

@Mouhajer-CO Mouhajer-CO Awaiting requested review from Mouhajer-CO

Assignees

@mel-am mel-am

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mel-am @harley-harris @Mouhajer-CO