Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getBooleanInput to parse flags #176

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Use getBooleanInput to parse flags #176

merged 4 commits into from
Mar 22, 2024

Conversation

sestrella
Copy link
Contributor

Closes #175

sestrella
sestrella commented Mar 21, 2024
View reviewed changes
action.yml
useDaemon:
description: "Push store paths to the cache as they're built with the Cachix Daemon"
default: true
default: 'true'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the GH Actions documentation, the default value of an input should be specified as a string:

image

Reference: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#inputsinput_iddefault

sandydoo
sandydoo requested changes Mar 21, 2024
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
sandydoo
sandydoo approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@sandydoo sandydoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@sandydoo
Copy link
Member

@sestrella, could you please run yarn build and commit the changes? Then I can merge this.

@sestrella
Copy link
Contributor Author

sestrella commented Mar 22, 2024 •
edited
Loading

@sandydoo done! Thank you for reviewing this so quickly.

@sandydoo sandydoo merged commit 033248a into cachix:master Mar 22, 2024
13 checks passed
@sestrella sestrella deleted the use_get_boolean_input_for_flags branch March 22, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandydoo sandydoo sandydoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use getBooleanInput to parse flags
2 participants
@sestrella @sandydoo