feat: Added kafka service #1565
Conversation
|
Update: I have added initial connectors to kafka connect, but they don't seem to persist when i restart kafka connect, not sure why. |
|
Okay, I figured it out, you could just pass the connectors to the start command |
|
Take a look at https://github.com/NixOS/nixpkgs/blob/nixos-unstable/nixos/modules/services/misc/apache-kafka.nix. You should be able to reuse large parts of this, particularly the config/settings handling, and ideally keep a similar interface. |
Also added defaults to run in kraft mode
|
Hey @sandydoo thanks for the feedback! I probably also need to create settings for kafka connect. I would also like to have some kind of readiness probe for kafka. TODO:
|
That's the right approach. @Alexnortung, is there a basic test we could add for this to make sure it launches? I'm not familiar with Kafka, but maybe a ping/healthcheck/queue-unqueue type of thing. See the |
|
Hi @sandydoo I have Added settings to kafka connect and added a test for kafka. |
| @@ -0,0 +1,3 @@ | |||
| set -e | |||
|
|
|||
| kafka-topics.sh --list --bootstrap-server localhost:9092 | |||
There was a problem hiding this comment.
Where does kafka-topics.sh come from?
There was a problem hiding this comment.
It's part of the apacheKafka package
There was a problem hiding this comment.
If you prefer we could probably also do a curl since the script is probably just calling an endpoint in kafka
Here is a rough implementation of a kafka service for devenv.
I think there are definetely place for configuration options. but I am not sure how we can implement this properly. So feedback would be appreciated :)
closes #1563