Intern event names and categories to save space in the trace output #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows strings like event names and event categories to be interned, thus the size of the resulting data can be significantly reduced.
Packet loss experiment in synthetic event is current not working.
shuhaowu
changed the title
shuhaowu
force-pushed
the
interned-string
branch
2 times, most recently
from
050f8c0 to
a7e657a
Compare
shuhaowu
force-pushed
the
interned-string
branch
from
a7e657a to
57adbf0
Compare
shuhaowu
force-pushed
the
interned-string
branch
from
57adbf0 to
44ca43b
Compare
shuhaowu
force-pushed
the
interned-string
branch
from
e9a9948 to
2ec2c23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows strings like event names and event categories to be interned, thus the size of the resulting data can be significantly reduced (-18%) for the
tracing_example, likely more for more "real" traces.This needed the protos to be synced from upstream with interned data.