Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverseproxy: ignore duplicate collector registration error #6820

Merged
merged 1 commit into from
Feb 4, 2025
Merged

reverseproxy: ignore duplicate collector registration error #6820

merged 1 commit into from
Feb 4, 2025

Conversation

mohammed90
Copy link
Member

I'm not very happy with the approach, but I cannot think of another one. Others who can see a better solution are welcome to suggest.

Fixes #6813

@mohammed90 mohammed90 added the bug 🐞 Something isn't working label Jan 31, 2025
@mohammed90 mohammed90 added this to the v2.9.2 milestone Jan 31, 2025
mholt
mholt approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it works as expected; the panic makes me a little nervous but I assume either that should never happen unless there's a bug, or the panic is necessary for flow control and it's unavoidable.

@mohammed90 mohammed90 merged commit 9283770 into master Feb 4, 2025
33 checks passed
@mohammed90 mohammed90 deleted the issue-6813 branch February 4, 2025 07:55
@mholt
Copy link
Member

mholt commented Feb 4, 2025

Thanks Mohammed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

@hairyhenderson hairyhenderson Awaiting requested review from hairyhenderson

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.9.2
Development

Successfully merging this pull request may close these issues.

panic: duplicate metrics collector registration attempted
2 participants
@mohammed90 @mholt