Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: slice loop replace #133

Closed
wants to merge 1 commit into from
Closed

chore: slice loop replace #133

wants to merge 1 commit into from

Conversation

testwill
Copy link

@testwill testwill commented Sep 4, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (45587ae) 37.08% compared to head (53ebcd6) 37.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   37.08%   37.19%   +0.10%     
==========================================
  Files          12       12              
  Lines         364      363       -1     
==========================================
  Hits          135      135              
+ Misses        228      227       -1     
  Partials        1        1              
Files Coverage Δ
internal/caddy/global/tls.go 26.08% <0.00%> (+1.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavimo
Copy link
Member

mavimo commented Nov 5, 2023

@testwill thx for your contribution, as reported in #173 this allow us to discover a unexpected behaviour, I'm going to close it in favour of #173 if you don't mind

@mavimo mavimo self-requested a review November 5, 2023 11:30
@testwill
Copy link
Author

testwill commented Nov 5, 2023

OK

@mavimo mavimo closed this Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants