Skip to content

Commit

Permalink
fix AutoConfigHint field propagation in frontend (#6587)
Browse files Browse the repository at this point in the history
New field was not passed to the wire correctly.
  • Loading branch information
shijiesheng authored Jan 2, 2025
1 parent 24f809f commit ab3d41c
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 0 deletions.
4 changes: 4 additions & 0 deletions common/types/mapper/proto/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -2178,6 +2178,7 @@ func FromPollForActivityTaskResponse(t *types.PollForActivityTaskResponse) *apiv
WorkflowType: FromWorkflowType(t.WorkflowType),
WorkflowDomain: t.WorkflowDomain,
Header: FromHeader(t.Header),
AutoConfigHint: FromAutoConfigHint(t.AutoConfigHint),
}
}

Expand All @@ -2202,6 +2203,7 @@ func ToPollForActivityTaskResponse(t *apiv1.PollForActivityTaskResponse) *types.
WorkflowType: ToWorkflowType(t.WorkflowType),
WorkflowDomain: t.WorkflowDomain,
Header: ToHeader(t.Header),
AutoConfigHint: ToAutoConfigHint(t.AutoConfigHint),
}
}

Expand Down Expand Up @@ -2250,6 +2252,7 @@ func FromPollForDecisionTaskResponse(t *types.PollForDecisionTaskResponse) *apiv
Queries: FromWorkflowQueryMap(t.Queries),
NextEventId: t.NextEventID,
TotalHistoryBytes: t.TotalHistoryBytes,
AutoConfigHint: FromAutoConfigHint(t.AutoConfigHint),
}
}

Expand All @@ -2274,6 +2277,7 @@ func ToPollForDecisionTaskResponse(t *apiv1.PollForDecisionTaskResponse) *types.
Queries: ToWorkflowQueryMap(t.Queries),
NextEventID: t.NextEventId,
TotalHistoryBytes: t.TotalHistoryBytes,
AutoConfigHint: ToAutoConfigHint(t.AutoConfigHint),
}
}

Expand Down
2 changes: 2 additions & 0 deletions common/types/mapper/thrift/matching.go
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ func FromMatchingPollForActivityTaskResponse(t *types.MatchingPollForActivityTas
WorkflowType: FromWorkflowType(t.WorkflowType),
WorkflowDomain: &t.WorkflowDomain,
Header: FromHeader(t.Header),
AutoConfigHint: FromAutoConfigHint(t.AutoConfigHint),
}
}

Expand All @@ -370,6 +371,7 @@ func ToMatchingPollForActivityTaskResponse(t *shared.PollForActivityTaskResponse
WorkflowType: ToWorkflowType(t.WorkflowType),
WorkflowDomain: t.GetWorkflowDomain(),
Header: ToHeader(t.Header),
AutoConfigHint: ToAutoConfigHint(t.AutoConfigHint),
}
}

Expand Down
4 changes: 4 additions & 0 deletions common/types/mapper/thrift/shared.go
Original file line number Diff line number Diff line change
Expand Up @@ -3589,6 +3589,7 @@ func FromPollForActivityTaskResponse(t *types.PollForActivityTaskResponse) *shar
WorkflowType: FromWorkflowType(t.WorkflowType),
WorkflowDomain: &t.WorkflowDomain,
Header: FromHeader(t.Header),
AutoConfigHint: FromAutoConfigHint(t.AutoConfigHint),
}
}

Expand All @@ -3614,6 +3615,7 @@ func ToPollForActivityTaskResponse(t *shared.PollForActivityTaskResponse) *types
WorkflowType: ToWorkflowType(t.WorkflowType),
WorkflowDomain: t.GetWorkflowDomain(),
Header: ToHeader(t.Header),
AutoConfigHint: ToAutoConfigHint(t.AutoConfigHint),
}
}

Expand Down Expand Up @@ -3665,6 +3667,7 @@ func FromPollForDecisionTaskResponse(t *types.PollForDecisionTaskResponse) *shar
Queries: FromWorkflowQueryMap(t.Queries),
NextEventId: &t.NextEventID,
TotalHistoryBytes: &t.TotalHistoryBytes,
AutoConfigHint: FromAutoConfigHint(t.AutoConfigHint),
}
}

Expand All @@ -3690,6 +3693,7 @@ func ToPollForDecisionTaskResponse(t *shared.PollForDecisionTaskResponse) *types
Queries: ToWorkflowQueryMap(t.Queries),
NextEventID: t.GetNextEventId(),
TotalHistoryBytes: t.GetTotalHistoryBytes(),
AutoConfigHint: ToAutoConfigHint(t.AutoConfigHint),
}
}

Expand Down
2 changes: 2 additions & 0 deletions common/types/testdata/service_frontend.go
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ var (
StartedTimestamp: &Timestamp2,
Queries: WorkflowQueryMap,
NextEventID: EventID3,
AutoConfigHint: &AutoConfigHint,
}
RespondDecisionTaskCompletedRequest = types.RespondDecisionTaskCompletedRequest{
TaskToken: TaskToken,
Expand Down Expand Up @@ -232,6 +233,7 @@ var (
WorkflowType: &WorkflowType,
WorkflowDomain: DomainName,
Header: &Header,
AutoConfigHint: &AutoConfigHint,
}
RespondActivityTaskCompletedRequest = types.RespondActivityTaskCompletedRequest{
TaskToken: TaskToken,
Expand Down
1 change: 1 addition & 0 deletions common/types/testdata/service_matching.go
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ var (
Header: &Header,
PartitionConfig: &TaskListPartitionConfig,
LoadBalancerHints: &LoadBalancerHints,
AutoConfigHint: &AutoConfigHint,
}
MatchingPollForDecisionTaskRequest = types.MatchingPollForDecisionTaskRequest{
DomainUUID: DomainID,
Expand Down

0 comments on commit ab3d41c

Please sign in to comment.