Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing timeout values for sql tool #4571

Closed
longquanzheng opened this issue Oct 15, 2021 · 1 comment
Closed

Allow passing timeout values for sql tool #4571

longquanzheng opened this issue Oct 15, 2021 · 1 comment
Labels
customer Feature asks from customer improvement Incremental improvement for existing features

Comments

@longquanzheng
Copy link
Contributor

longquanzheng commented Oct 15, 2021

Changing schema like adding a new field could take some time. Currently the timeout is hardcoded.

This is a problem for sql tool because one of the steps could get timeout and fails. Then the sql couldn’t rerun because some steps are already executed.

Making sql tool to be idempotent is ideal way but it’s a lot of work to do. The easier way to mitigate for now is allowing passing a timeout value for the command. The timeout value will be used for executing any sql query.

This will be much easier done after this PR to introduce passing a context.Context into the interface #4561

@ibarrajo ibarrajo added customer Feature asks from customer improvement Incremental improvement for existing features labels Nov 4, 2024
@ibarrajo
Copy link
Contributor

ibarrajo commented Nov 4, 2024

While this has not been implemented, I found no reports of a timeout during a schema change. I think since we prefer adding new columns over changing data types for the fields.

https://github.com/uber/cadence/blob/c7dfbd634aaa89ca1131a8e668cab39b6df9c6d8/tools/sql/conn.go#L75-L80

@ibarrajo ibarrajo closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer Feature asks from customer improvement Incremental improvement for existing features
Projects
None yet
Development

No branches or pull requests

2 participants