Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform schema checks for multiple SQL database and add context to AdminDB DDL interface #4561

Merged
merged 17 commits into from
Oct 26, 2021
Merged

Perform schema checks for multiple SQL database and add context to AdminDB DDL interface #4561

merged 17 commits into from
Oct 26, 2021

Conversation

longquanzheng
Copy link
Contributor

@longquanzheng longquanzheng commented Oct 11, 2021 •
edited
Loading

What changed?

  1. Perform schema checks for multiple SQL database
  2. Add context.Context to execDDL interface so that CLI and add timeout option later

Why?
For #4509

How did you test it?

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented Oct 11, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 3cc81060-7038-49ef-a231-03d0b86e5c85

  • 304 of 342 (88.89%) changed or added relevant lines in 10 files are covered.
  • 10 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 56.925%
Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/sql/sqldriver/singleton.go 2 4 50.0%
tools/common/schema/handler.go 1 3 33.33%
tools/common/schema/updatetask.go 0 2 0.0%
tools/cassandra/cqlclient.go 1 7 14.29%
common/persistence/sql/sqlplugin/mysql/admin.go 4 11 36.36%
common/persistence/sql/sqlplugin/postgres/admin.go 4 11 36.36%
common/persistence/sql/sqldriver/sharded.go 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
common/membership/rpServiceResolver.go 2 73.58%
common/persistence/sql/sqldriver/sharded.go 3 0%
common/task/fifoTaskScheduler.go 5 84.54%
Totals Coverage Status
Change from base Build 848010f1-1548-4ec7-87dc-5f5d0df24565: 0.1%
Covered Lines: 81923
Relevant Lines: 143915
💛 - Coveralls

@github-actions github-actions bot force-pushed the qlong-multi-sql-schema-check branch from 01771bd to 22197f4 Compare October 11, 2021 17:57
@longquanzheng longquanzheng mentioned this pull request Oct 15, 2021
Closed
@longquanzheng longquanzheng force-pushed the qlong-multi-sql-schema-check branch from 22197f4 to 6acfa9b Compare October 21, 2021 04:29
@longquanzheng longquanzheng changed the title [WIP] Perform schema checks for multiple SQL database Perform schema checks for multiple SQL database Oct 21, 2021
@longquanzheng longquanzheng marked this pull request as ready for review October 21, 2021 04:37
@longquanzheng longquanzheng force-pushed the qlong-multi-sql-schema-check branch from 083fe36 to 8692fb5 Compare October 23, 2021 02:52
@longquanzheng longquanzheng force-pushed the qlong-multi-sql-schema-check branch from 8692fb5 to 24d1e2a Compare October 26, 2021 00:57
@longquanzheng longquanzheng changed the title Perform schema checks for multiple SQL database Perform schema checks for multiple SQL database and add context to AdminDB DDL interface Oct 26, 2021
@longquanzheng longquanzheng enabled auto-merge (squash) October 26, 2021 00:58
@longquanzheng longquanzheng merged commit 085a799 into master Oct 26, 2021
@longquanzheng longquanzheng deleted the qlong-multi-sql-schema-check branch October 26, 2021 01:19
@longquanzheng longquanzheng mentioned this pull request Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaddoll Shaddoll Shaddoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@longquanzheng @coveralls @Shaddoll