Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[make] Fix .idl submodule check #6628

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

3vilhamster
Copy link
Contributor

@3vilhamster 3vilhamster commented Jan 16, 2025

What changed?
Updated the check of idls submodule for master since it was not working if you have out of date master or didn't pull it for a while.

Example failure:

cd idls
git checkout b25b18cb10b1d3880cbb7525811ce5f61a348758
make .idl-status

Error: Submodule commit b25b18cb10b1d3880cbb7525811ce5f61a348758 belongs to   origin/feature-dt-kind, not to master branch
make: *** [.idl-status] Error 1

Why?
The check was failing on fresh repo after git submodule update --init, since it does not fetch recent master.

How did you test it?
Checked on master and checked on the non-master commit.

Potential risks
CI fail, should be easy to rollback in case of issues.

Release notes

Documentation Changes

@Groxx
Copy link
Member

Groxx commented Jan 16, 2025

I kinda wonder if git changed somewhere along the way, because I'm getting empty results from the current code...

... but eh. This looks better regardless, it was a moderate hack before and branch --contains (and --remote) seems like a clearly more reasonable check to do. Thanks!

@3vilhamster 3vilhamster merged commit c8a889d into cadence-workflow:master Jan 16, 2025
22 checks passed
@3vilhamster 3vilhamster deleted the fix-idl-status branch January 16, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants