Sampling on emitting misconfigured partition metrics #6650
Closed
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
abhishekj720
approved these changes
Jan 30, 2025
|
Closed this for https://github.com/cadence-workflow/cadence/pull/6651/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add a sampling rate to reduce emitting metrics on misconfigured partition.
Why?
The metrics emitting fetches all pollers for the tasklist. This is an expensive call.
How did you test it?
Will test in staging to verify metrics emitting frequency
Potential risks
low to no risk since it's metrics only logic
Release notes
Documentation Changes