Introduce task scheduler rate limiter #6677
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
requested review from
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
Shaddoll
commented
Feb 19, 2025
|
|
||
| func (r *taskRateLimiterImpl) Wait(ctx context.Context, t Task) error { | ||
| limiter, scope, shadow := r.getLimiter(t) | ||
| rsv := limiter.Reserve() |
There was a problem hiding this comment.
@Groxx Is it the correct usage?
| domainID := t.GetDomainID() | ||
| domainName, err := r.domainCache.GetDomainName(domainID) | ||
| if err != nil { | ||
| r.logger.Warn("failed to get domain name from domain cache", tag.WorkflowDomainID(domainID), tag.Error(err)) |
There was a problem hiding this comment.
What will r.limiters.For(domainName) return for non-existing domains? Should we return here while handling err instead of letting the below line execute?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Introduce task scheduler rate limiter which is disabled by default. If enabled, it will run in shadow mode for all domains by default.
Why?
How did you test it?
unit tests, also tested in dev2
Potential risks
history task scheduler might be broken
Release notes
Documentation Changes