[Wf-Diagnostics] use current clustername for emission of usage logs #6678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sankari165
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
3vilhamster
approved these changes
Feb 19, 2025
|
saw the comment slightly late but it is hard to add a test since the data sent to emission of usage logs includes the time taken for the child wf execution and felt like too much info for unit tests |
Assem-Uber
pushed a commit
that referenced
this pull request
Feb 20, 2025
…6678) * [Wf-Diagnostics] use current clustername for emission of usage logs * Update module.go
Assem-Uber
pushed a commit
that referenced
this pull request
Feb 20, 2025
…6678) * [Wf-Diagnostics] use current clustername for emission of usage logs * Update module.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
current clustername used in data for emission of usage logs
Why?
to provide insights into where diagnostics is used
How did you test it?
Potential risks
Release notes
Documentation Changes