Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step Type Query #91
Step Type Query #91
Changes from 6 commits
d82f97b
c822ae3
3e73169
02a7f7a
d49014d
31a7713
5c4b2c3
edc89b1
fb5ea06
0733da1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these are needed, since the edge validity already exists, we only need to check what type of edge it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The step types aren't stored anywhere when the graph is generated, so I have to call
dhart/src/Cpp/analysismethods/src/graph_utils.cpp
Lines 303 to 308 in 7587a53
which takes these parameters as input. The parameters are actively used in code blocks such as
dhart/src/Cpp/analysismethods/src/graph_utils.cpp
Lines 338 to 345 in 7587a53
The workaround I had for this was using default values for these parameters corresponding the the default values in the
GraphGenerator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disregard my previous comment, I can remove the parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the unnecessary parameters and replaced the corresponding UnitTests with more complex ones. My initial PR is updated with any new functions I made.