Build kernel with KFT instrumentation #1393
Conversation
franciscozdo
added
review
There was a problem hiding this comment.
I would much appreciate if you renamed kft.{c,h} to kftrace.{c,h} respectively.
Please note that most likely kft.h should be renamed to cpufunc.h and the function should be renamed to cpu_getcounter. But that would require some cleanup effort, which we don't want to incur ATM.
franciscozdo
added
WiP
franciscozdo
added
review
config.mk
Outdated
| @@ -4,7 +4,7 @@ | |||
| # build system for given platform. | |||
| # | |||
|
|
|||
| CONFIG_OPTS := KASAN LOCKDEP KGPROF MIPS AARCH64 RISCV KCSAN | |||
| CONFIG_OPTS := MIPS AARCH64 RISCV KASAN LOCKDEP KCSAN KGPROF KFTRACE | |||
There was a problem hiding this comment.
Please don't reorder the options if you don't need to. What about KGPROF and KFTRACE now, shouldn't they be replaced by KFI?
There was a problem hiding this comment.
I have added them to make it possible to include sources that are saved in variables SOURCES_KFTRACE and SOURCES_KGPROF. I couldn't figure it out how to do it with single KFI flag.
I will reorder back the other flags.
sys/kern/kftrace.c
Outdated
| static unsigned kft_used = 0; | ||
| static bool kft_enabled = false; | ||
|
|
||
| #define PC_MASK 0xFFFFFF /* 24 bits */ |
There was a problem hiding this comment.
Please note that lower two bits won't be used on all architectures with 4-byte only instruction words (i.e. all that we support currently).
This PR contains only changes made to kernel to create data about function calls. There will be another PR with python code which will interpret this data.