Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve labels #10

Merged
merged 1 commit into from
May 6, 2022
Merged

Improve labels #10

merged 1 commit into from
May 6, 2022

Conversation

LDSamson
Copy link
Contributor

@LDSamson LDSamson commented May 3, 2022

Improve support for longer label names. It introduces vertical labels on the x-axis labels when necessary, and expands the plot area dynamically by label length.

Addresses this issue.

improve support for longer label names - vertical labels on x-axis, expand plot area dynamically by label length
@caijun
Copy link
Owner

caijun commented May 6, 2022

@LDSamson thanks for addressing issue #8. I will merge your PR and add you as a contributor.

@caijun caijun merged commit 8441cf2 into caijun:master May 6, 2022
@caijun
Copy link
Owner

caijun commented May 6, 2022

@LDSamson I have merged your pull request. Could you please add yourself as a contributor in the DESCRIPTION? Then I will update the citation in the ReadMe page.

@LDSamson LDSamson deleted the improve_labels branch May 7, 2022 10:09
@LDSamson LDSamson restored the improve_labels branch May 7, 2022 10:20
@LDSamson
Copy link
Contributor Author

LDSamson commented May 7, 2022

Thanks that you want to add me as a contributor! I've added my name in the improve_labels branch. Should I make a new pull request for it?

@caijun
Copy link
Owner

caijun commented May 7, 2022

yes, you need to make a new PR and I will merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants