forked from freeCodeCamp/freeCodeCamp
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating #1
Merged
Merged
updating #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fix(curriculum):build an rpg- step 39-fixed typo Co-authored-by: Andriy Kozlovsky <[email protected]>
fix(curriculum): Capitalize abbreviation: JSON
* Re-worded reset code button in js lessons * Made suggested changes in translation.json and lower-jaw.tsx * Updated 'reset-step' translation
* feat(client): add ES GTM id * Update client/src/analytics/index.ts Co-authored-by: Oliver Eyton-Williams <[email protected]> Co-authored-by: Oliver Eyton-Williams <[email protected]>
* feat: integrate the odin project * feat: add assignment to markdown parser * feat: add assignment logic * fix: doe not always show assignment block * fix: some other stuff * fix: introdiction to html and css questions * fix: remove assignments after first question * fix: update snapshots and tests * feat: create rest of HTML foundation course structure * feat: meta file * feat: add descriptions to 'html boiler plate' questions * feat: add description for 'working with text and list items' * fix: multiple logic issues * fix: make linter happy * feat: add description for 'links and images' questions * fix: add assignments to Joi schema * fix: tests * fix: schema * fix: add help category * fix: change to possessive wording * fix: set upcoming change to true in meta file * fix: spell unordered and ordered correctly * fix: switch order in meta * fix: spell boilerplate correctly * feat: add final project * chore: add more tests to the final project * fix: question spelling * Apply suggestions from code review Co-authored-by: Naomi Carrigan <[email protected]> * Apply suggestions from code review Co-authored-by: Naomi Carrigan <[email protected]> * Apply suggestions from code review Co-authored-by: Naomi Carrigan <[email protected]> * Apply suggestions from code review Co-authored-by: Naomi Carrigan <[email protected]> * Apply suggestions from code review Co-authored-by: Naomi Carrigan <[email protected]> * Apply suggestions from code review Co-authored-by: Naomi Carrigan <[email protected]> * fix: translation * Update client/i18n/locales/english/translations.json Co-authored-by: Oliver Eyton-Williams <[email protected]> * fix: create new challenge type * fix: get the new challenge type working and remove ol css * fix: translation location * fix: add challenge type to epic * fix: set correct video * fix: max challengeType number * fix: spelling/grammar errors in project * fix: check if anchor tags is empty * Apply suggestions from code review Co-authored-by: Oliver Eyton-Williams <[email protected]> * Update tools/challenge-parser/parser/plugins/add-video-question.js Co-authored-by: Oliver Eyton-Williams <[email protected]> * chore: multiple suggestions * chore: separate assignments into different plugin * Apply suggestions from code review Co-authored-by: Kristofer Koishigawa <[email protected]> * fix: dubble answer header after review * fix: issue with Gatsby hopefully * fix: add assignments to Gatsby's Challenge schema * Update curriculum/schema/challengeSchema.js Co-authored-by: Oliver Eyton-Williams <[email protected]> Co-authored-by: Naomi Carrigan <[email protected]> Co-authored-by: Oliver Eyton-Williams <[email protected]> Co-authored-by: Kristofer Koishigawa <[email protected]>
Co-authored-by: Oliver Eyton-Williams <[email protected]> Co-authored-by: Sem Bauke <[email protected]>
…49148) * feat(client): make portfolio section in profile support RTL layout * Revert "feat(client): make portfolio section in profile support RTL layout" This reverts commit b4cf5f1. * make media component responsive * fix the selector * hook the media left through an id * hook the media left through an id
Start converting es6 javascript.
* feat(client) make pre in instruction ltr when the layout is rtl * revert the changes in the markdown file
fix(curriculum):replaced non-virtual DOM elements phrase with DOM elements
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
feat(client): move percent calculation logic to epic
…49391) * feat: remove extra unnecessary code * clean the unique way that component was handled * make bsSize optional * update snapshot to account for the other button styles * add comment for our future selves * clean the changes file
* docs: update reload instructions * Update docs/devops.md Co-authored-by: Oliver Eyton-Williams <[email protected]> * Update docs/devops.md Co-authored-by: Oliver Eyton-Williams <[email protected]> * fix: remove errant spaces Co-authored-by: Naomi Carrigan <[email protected]> --------- Co-authored-by: Oliver Eyton-Williams <[email protected]> Co-authored-by: Naomi Carrigan <[email protected]>
…p-13] (#49436) feat(curriculum): remove target attribute seed code from step 13 in CatPhotoApp
* fix(client): correctly return type from selector * fix(client): remove incorrect prop [button-spacer]
Fixed sum-all-odd-fibonacci-numbers.md text
* fix: optional video ids the odin project * Update client/src/templates/Challenges/odin/Show.tsx Co-authored-by: Niraj Nandish <[email protected]> --------- Co-authored-by: Niraj Nandish <[email protected]>
* fix: remove unused className spacer from spacer helper --------- Co-authored-by: jeff <[email protected]>
fix: provide return types I also moved the undefined check closer to the source, so it's clearer what is missing
* refactor(client): clean some mistype errors in the nav-links file * fix showLanguage prop type in the other files * add-ts-ignore-comment * swap to map for easier maintainablity * Change the eslint naming comment * fix: using the wrong handlekeydown function Co-authored-by: Bruce B <[email protected]> * hide the menu when focus is on the userimage * hide the menu only if camper didn't press shift key --------- Co-authored-by: Bruce B <[email protected]>
* feat(client): remove react lazy loader library * fix: use loading='lazy' to defer loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md
)main
branch of freeCodeCamp.Closes #XXXXX