Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigating infra pipeline logic #285

Closed
wants to merge 12 commits into from
Closed

Investigating infra pipeline logic #285

wants to merge 12 commits into from

Conversation

angela-tran
Copy link
Member

I'm opening this to see what the Azure pipeline does when opening a PR from dev into test.

Based on the code, it seems like it will run terraform apply on the "test" workspace even though all we did was open a PR. This implies the terraform apply that runs on merging the PR would be a no-op. (I'm not actually going to merge this PR. Just want to look at the results of opening the PR.)

@angela-tran angela-tran self-assigned this Aug 7, 2023
@angela-tran angela-tran requested a review from a team as a code owner August 7, 2023 21:17
@angela-tran
Copy link
Member Author

The infra pipeline ran terraform plan on the test workspace, so it works as one would think it should - i.e. no bug! 🙌

The code (i.e. condition for running terraform plan) is just a little misleading because of the nuance of Build.SourceBranchName. I was able to find #177 which helped me realize that Build.SourceBranchName is only populated on IndividualCI runs (i.e. merges).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants