Feat: figure out infra pipeline tag trigger by experimenting #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
7 times, most recently
from
9dbdd8c
to
42ef022
Compare
14 tasks
after experimenting, I found that this works the same as using branch
revert original pipeline back
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
from
79bc6e7
to
93e398d
Compare
also improve the wildcard usage in tag filter and in the regex used in workspace selection logic.
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
from
c5ea724
to
ae96cd2
Compare
getting error: > Job terraform: Step references task 'ManualValidation' > at version '0.198.0' which is not valid for the given job target.
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
from
ae96cd2
to
14f49b5
Compare
approval check lets you configure more parameters around approvers
it's different for stage vs. job
to get a nicer looking environment name, e.g. use the workspace name, we would have to do a 'composed' pipeline since the environment property cannot be a variable - see https://stackoverflow.com/q/68545603 this doesn't seem worth it, so going back to just using a simple name
update path filter
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
from
64d3e55
to
ff1f212
Compare
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
4 times, most recently
from
259e7ec
to
96fda0a
Compare
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
from
fe0da5f
to
a79f07f
Compare
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
2 times, most recently
from
3b09ffd
to
7efb502
Compare
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
from
7efb502
to
8dfe841
Compare
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
2 times, most recently
from
67d5700
to
af50184
Compare
angela-tran
force-pushed
the
feat/infra-pipeline-tag-trigger
branch
from
af50184
to
4b13800
Compare
angela-tran
changed the title
|
Closing this PR now that experimentation on the infra pipeline has concluded - see #310 for actual changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #284