Don't call ps in the context of xcrun #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmoody 👍 Looks good. Is it best practice for the assignee to merge the PR as well? Out of curiosity, why is one command run with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Completes replaces calls to
xcrun pswithpsJIRA.In Xcode 8,
psis not available in the context ofxcrun- this is causing the unit test runner in DeviceAgent.iOS to fail.After reviewing the code, I created this issue Create a class or module for interacting with
ps#487 which is part of this epic Pass allreadcalls through utf-8 filter #230.