-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] add hero section #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oahnh
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! just a couple styling nits for color & spacing so we don't have to go back later
} | ||
|
||
// each word | ||
.word { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i mite borrow this for my personal site 🤓
jinkang-0
force-pushed
the
jinkang/hfi-13-hero-section
branch
3 times, most recently
from
January 11, 2024 06:47
615bf5d
to
139ed73
Compare
jinkang-0
force-pushed
the
jinkang/hfi-13-hero-section
branch
from
January 11, 2024 07:07
139ed73
to
d1095dd
Compare
oahnh
pushed a commit
that referenced
this pull request
Jan 11, 2024
* update hero * update text styles, minor adjustment to hero layout * remove changes to env.d.ts * tell prettier to ignore env.d.ts * tell lint to ignore env.d.ts * update scroll behavior and padding * microscopic edits * add bouncing arrow
christophertorres1
pushed a commit
that referenced
this pull request
Jan 11, 2024
* update hero * update text styles, minor adjustment to hero layout * remove changes to env.d.ts * tell prettier to ignore env.d.ts * tell lint to ignore env.d.ts * update scroll behavior and padding * microscopic edits * add bouncing arrow
jinkang-0
added a commit
that referenced
this pull request
Jan 12, 2024
* feat(faq): adds faq section * [feat] add button component (#8) * add graphics, button * update global button style * update button styles * [feat] add nav bar (#9) * update navbar, h5 global style * update navbar height * [feat] add footer (#12) * add footer * remove edit to env.d.ts * use astro image for optimization * remove edit to env.d.ts * [feat] add hero section (#11) * update hero * update text styles, minor adjustment to hero layout * remove changes to env.d.ts * tell prettier to ignore env.d.ts * tell lint to ignore env.d.ts * update scroll behavior and padding * microscopic edits * add bouncing arrow * add padding-top to Contact section (#14) * fix(types): moves question type definition to FAQDropdown component * [feat] create about section (Our Vision, The Mission) (#13) * create skeleton * change div to section * fill out Our Mission + Vision * add and use b * clean up / remove comments * check style (prettier) * remove b from global styles * create div for mission and vision * feat(faq): adds faq section * fix(types): moves question type definition to FAQDropdown component * refactor: addresses review comments * refactor(faq): adjusts container width, updates keydown functionality --------- Co-authored-by: Jinkang Fang <[email protected]> Co-authored-by: ccatherinetan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
Note: This PR extends from the button PR - review that first.
(gif cuts off but it is a smooth infinite cycle)
Linear Task
https://linear.app/hack-for-impact-2024/issue/HFI-13/hero-section