Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miha phs 37 #36

Merged
merged 31 commits into from
Mar 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
73fb493
ra
sarahhpeng Nov 20, 2023
6a911d8
fix phs 26 changed display.id to otherDisplay.id
sarahhpeng Nov 20, 2023
8d4648b
raaaaa
sarahhpeng Nov 21, 2023
87f4b28
phs-37 is done
miha-bhaskaran Feb 13, 2024
48f4ad9
changed settings josn
miha-bhaskaran Feb 22, 2024
50e9b1e
Christophertorres/phs 36 featured tours image carousel (#37)
christophertorres1 Feb 25, 2024
c6456f3
fix: minor styling changes to meet larger text inputs
andreisito Dec 2, 2023
9ec5efc
feat: more linting
andreisito Mar 10, 2024
15050fb
feat: more linting II
andreisito Mar 10, 2024
3428ba6
chore: pre-push reformatting
andreisito Mar 10, 2024
bbc19c7
feat: aggressive pre-commit checks
andreisito Mar 10, 2024
6ca7c6a
feat: use lint-staged instead
andreisito Mar 11, 2024
695a486
chore: updated types
andreisito Mar 11, 2024
6253d74
feat: run tsc on staged files
andreisito Mar 11, 2024
0da6ef2
chore
andreisito Mar 11, 2024
b8beb4f
feat: disabling github actions until MPH / post-MPH
andreisito Mar 11, 2024
afc2db9
chore: prettier
andreisito Mar 11, 2024
f4bfd34
chore: disabled only the tsc compiler for now
andreisito Mar 11, 2024
7f94351
feat: disabling github actions for now
andreisito Mar 16, 2024
66c4342
Andrei/phs 25 home screen redo (#38)
andreisito Mar 16, 2024
f300071
commit limits
sarahhpeng Nov 21, 2023
2772e24
phs-37 is done
miha-bhaskaran Feb 13, 2024
e68447d
donw with committing
miha-bhaskaran Mar 16, 2024
9b0617d
ra
sarahhpeng Nov 20, 2023
74008b4
fix phs 26 changed display.id to otherDisplay.id
sarahhpeng Nov 20, 2023
9693860
raaaaa
sarahhpeng Nov 21, 2023
3422355
phs-37 is done
miha-bhaskaran Feb 13, 2024
67c97c6
commit limits
sarahhpeng Nov 21, 2023
80d91a1
phs-37 is done
miha-bhaskaran Feb 13, 2024
efba220
donw with committing
miha-bhaskaran Mar 16, 2024
c8abdcc
Merge branch 'miha-phs-37' of github.com:calblueprint/phs into miha-p…
miha-bhaskaran Mar 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 65 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
# ---
# name: Lint

# #############################
# # Start the job on push #
# #############################
# on:
# push:
# branches-ignore: [main]
# pull_request:
# branches: [main]

# ###############
# # Set the Job #
# ###############
# jobs:
# build:
# # Name the Job
# name: Run ESLint, Prettier, and TypeScript compiler
# # Set the agent to run on
# runs-on: ubuntu-latest

# ##################
# # Load all steps #
# ##################
# steps:
# ##########################
# # Checkout the code base #
# ##########################
# - name: Checkout Code
# uses: actions/checkout@v3
# with:
# # Full git history is needed to get a proper
# # list of changed files within `super-linter`
# fetch-depth: 0

# ################################
# # Install packages #
# ################################
# - name: Install packages
# run: npm ci
# ################################
# # Lint codebase #
# ################################
# - name: Run ESLint
# run: npx lint-staged
# ################################
# # Check Prettier on codebase #
# ################################
# - name: Run Prettier
# run: npx prettier --check .
# ################################
# # Check for TypeScript errors #
# # TODO: Add this back once outstanding issues are resolved by all devs.
# ################################
# # - name: Run TypeScript compiler (tsc) on staged files
# # run: |
# # # Get list of staged TypeScript files
# # files=$(git diff --cached --name-only --diff-filter=d | grep '\.tsx\?$')

# # # Run tsc on each file
# # for file in $files
# # do
# # npx tsc --noEmit $file || exit 1
# # done
3 changes: 1 addition & 2 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npm run prettier
npm run update-types
npm run pre-commit
9 changes: 9 additions & 0 deletions .vscode/css_custom_data.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"version": 1.1,
"atDirectives": [
{
"name": "@tailwind",
"description": "Use the @tailwind directive to insert Tailwind's `base`, `components`, `utilities`, and `screens` styles into your CSS."
}
]
}
2 changes: 1 addition & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true
"source.fixAll.eslint": "explicit"
},
"typescript.tsdk": "node_modules/typescript/lib"
}
Loading