feat(map): adds preview component, updates UI #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ New in this PR ✨
One liner: what did you do? 🛠
adds a preview component to the map
Coverage 🙆♀️
use this section to break up your task into submodules and track progress, copy from Linear and mark what was completed
DisplayPreviewcomponentNext Steps:
Currently, the preview card isn't responsive. It doesn't appear centered in some devices. Although I defined a new component to allow us to overlay the preview card, I want to look into a refactor to more safely and responsively (like this).
Additionally, there have been a chunk of UI updates to the map that should also be handled before merging (marker icons, etc.)
How can the reviewer test your code? Where is this sprint located in the codebase? 👩💻
REQUIRED: Link a short video demo of the feature you have added. 👩💻
Any bugs you encountered or still having trouble with? 🐛
Resources 📔
https://stackoverflow.com/questions/23762176/leaflet-custom-control-position-center
REQUIREMENTS in this section: Link all relevant online resources and related PRs. Write down any new dependencies or packages and link to their documentation. If you ran into bugs, link any stack overflow or online resources that helped you unblock yourself
❗IF this sprint was marked as FRONTEND on linear, cc Claire Wang
REMEMBER: once PR is made, also request a PR review Sarah, CC'ing is NOT enough!
🏚 cc: @sarahhpeng @andreisito