Buyankhuu/new footer #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
caseyzlei
reviewed
Nov 3, 2023
|
|
||
| import { FooterDiv, ContactDiv } from '../styles/components'; | ||
|
|
||
| export default function Logo() { |
There was a problem hiding this comment.
change the function name, Logo gets reused across multiple pages rn. generally good practice is to name it after the page or component i.e. here it would be export default function Footer()
| @@ -0,0 +1,17 @@ | |||
| import { LocationDiv, Addie } from '../styles/components'; | |||
|
|
|||
| export default function Logo(props: { | |||
There was a problem hiding this comment.
same thing here abt function names, name it something like Location()
| display: flex; | ||
| flex-direction: row; | ||
| color: black; | ||
| width: 90%; |
There was a problem hiding this comment.
NO PERCENTAGES (unless u are doing 100%)--stick w pixels unless told otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a popup using toasty for the logout button which will redirect the user to the login screen.
Footer for all the pages was created
New components:
Footer: the entirety of the footer
location: the small div with the text of each location that Shanti has
added the logo to the login screen and got rid of the yellow box
Screenshots
https://www.loom.com/share/58a7630a1d24461597a765d1afb769ac?sid=f2700b80-fcc4-4901-b9bb-6ff3e24f70b2
How to review
Order: Component/Location -> Component/Footer -> style/component -> Profile/page -> Profile/style
Testing:
go to localhost
go to each page and scroll to the bottom to see the footer
navigate to localhost/profile
press logout -> popout shows up -> send user to login page
Next steps
next step: see if design of footer changes/ popup
Relevant Links
Online sources
Related PRs
🛍 CC: @EthanAuyeung