chore: remove not used code related to filters on /bookings #19450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjae-lee
force-pushed
the
chore/remove-unused-code-from-bookings
branch
from
b2f1247 to
09031c7
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
eunjae-lee
force-pushed
the
chore/remove-unused-code-from-bookings
branch
from
4aab84d to
75dcc04
Compare
eunjae-lee
changed the title
dosubot
bot
added
the
bookings
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/21/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (02/24/25)1 reviewer was added to this PR based on Keith Williams's automation. |
eunjae-lee
force-pushed
the
chore/remove-unused-code-from-bookings
branch
2 times, most recently
from
83dc7a8 to
3de589e
Compare
Udit-takkar
reviewed
Feb 24, 2025
| export const ZLegacyListMembersInputSchema = ZListMembersInputSchema.extend({ | ||
| includeEmail: z.boolean().optional(), | ||
| }); | ||
| export const ZLegacyListMembersInputSchema = ZListMembersInputSchema.extend({}); |
There was a problem hiding this comment.
can't this be just
export const ZLegacyListMembersInputSchema = ZListMembersInputSchema
There was a problem hiding this comment.
or just use ZListMembersInputSchema
There was a problem hiding this comment.
@Udit-takkar thanks! I've actually deleted this in #19445 just now (this is a stacked PR on top of it)
eunjae-lee
force-pushed
the
chore/remove-unused-code-from-bookings
branch
from
3de589e to
47b0979
Compare
eunjae-lee
force-pushed
the
chore/remove-unused-code-from-bookings
branch
from
47b0979 to
62c8588
Compare
hbjORbj
previously approved these changes
Feb 24, 2025
Base automatically changed from
eunjae/cal-5178-replace-filter-implementations-on-bookings
to
main
February 24, 2025 16:11
eunjae-lee
force-pushed
the
chore/remove-unused-code-from-bookings
branch
from
62c8588 to
0e3c025
Compare
hbjORbj
approved these changes
Feb 24, 2025
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Due to the changes in #19445, we can remove some code that is not used anymore.
Mandatory Tasks (DO NOT REMOVE)